Synfig Issue Tracker
star_faded.png
Please log in to bookmark issues
bug_report_small.png
CLOSED  Bug report #160  -  Shortcuts not consistent
Posted Dec 22, 2012 - updated Jan 05, 2019
action_vote_minus_faded.png
0
Votes
 action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Fixed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Bug report
  • Status
     
    		 Fixed
  • Assigned to
    Not assigned to anyone
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
    Imported User
  • Owned by
    Not owned by anyone
  • Category
    User interface
  • Resolution
    RESOLVED
  • Priority
    Not determined
  • Targetted for
    icon_milestones.png Not determined
  • Tags
    icon_customdatatype.png Not determined
  • Difficulty
    icon_customdatatype.png Not determined
Issue description
rylleman:

Canvasview shortcuts only works when actual canvas window is selected.

This was introduced with the fix of Bug report 159 - Keyboard shortcuts interferes with param values. Previously canvas shortcuts worked consistently over the UI, no matter which window was in focus.
Steps to reproduce this issue
Nothing entered.

#3
Comment posted by
Imported User
Dec 22, 18:14
Konstantin Dmitriev:

Yes, this can produce some issues. For example, if I select one or two layers in layers Panel and press Ctl+A, then it selects all layers in layers panel instead of selecting all ducks in the canvas (like old behaviour). To select all ducks I must activate canvas window before pressing Ctl+A...

Another thing: when canvas window is active focus often goes to the "Quality" spinbox in the toolbar at the top. If that happening then I can't use Ctrl+. and Ctrl+, keyboard shortcuts to navigate to next/prev frame. I guess maybe this issue will be fixed when Jcome will fix toolbar widget...
#4
Comment posted by
Imported User
Dec 22, 18:15
genete:

This behanvior is the result of fix the bug introduced in Bug report 159 - Keyboard shortcuts interferes with param values.

The old behavior was that any key pressing was handled by the application shortcuts system before being handled by the currently focused widget. This produced that for example, when editing a parameter and pressing the "home" key, the time cursor responded going to the start of the animation instead of placing the cursor at the begining of the widget in edition.

The fix of Bug report 159 - Keyboard shortcuts interferes with param values is to ask the current widget to handle the keyboard combination and if it is not handled, then call the main applicaiton shortcut handler to process the key stroke.

So the final solution is to, one by one, define what key strokes should be handled or not handled by each widget type and in case it is not handled let the global shorcut keys handle it.

#5
Comment posted by
Imported User
Dec 22, 18:15
genete:

I'll open a forum thread to discuss which keyboard shortcuts should be handled by each widget or not.
#6
Comment posted by
Imported User
Dec 22, 18:16
rylleman:

Shouldn't widgets be allowed to override key shortcuts only if a widget input box is in edit/input mode? Would this be possible to do?

To define which key strokes is to be allowed as shortcuts or not can become confusing to the user, and unwanted limitation may show up.

If this is the only solution then I think the behaviour before 3472549 was fixed is better. There is then a limitation on which shortcuts can be practically used but the shortcut behaviour is consistent, no matter which window is currently in focus.
#7
Comment posted by
Imported User
Dec 22, 18:16
genete:

Fixed on 0.63.05
#8
Comment posted by
Konstantin Dmitriev
Dec 22, 18:16
Fixed by genete

The issue was updated with the following change(s):
  • This issue has been closed
  • The status has been updated, from New to Fixed.
  • This issue's progression has been updated to 100 percent completed.
  • The resolution has been updated, from Not determined to RESOLVED.