Synfig Issue Tracker
star_faded.png
Please log in to bookmark issues
bug_report_small.png
OPEN  Bug report #69  -  Incorrect use of pipe system call
Posted Dec 16, 2012 - updated Jan 05, 2019
action_vote_minus_faded.png
0
Votes
action_vote_plus_faded.png
Issue details
  • Type of issue
    Bug report
  • Status
     
    New
  • Assigned to
    Not assigned to anyone
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
     Imported User
  • Owned by
    Not owned by anyone
  • Category
    Not determined
  • Resolution
    Not determined
  • Priority
    Not determined
  • Targetted for
    icon_milestones.png Not determined
  • Tags
    icon_customdatatype.png Not determined
  • Difficulty
    icon_customdatatype.png Easy
Issue description
Gerco Ballintijn:

In src/synfig/render.cpp (line 338) the pipe() system call is used incorrectly. The pipe() call uses with two adjacent local integer variables instead of the required single array of 2 integers. It currently works, but is not guaranteed to work.
Steps to reproduce this issue
Nothing entered.

#3
Comment posted by
 djay
Jul 22, 15:48
Incorrect code is now in line 451.

Seems very easy to correct and maybe will give some stability for win32 platform. It's present in between a preprocessor win32 condition i my case, i can't resolve, i don't have this platform.
#4
Comment posted by
 Charlie Murphy
Dec 31, 23:09
If the pipe() call you pointed out is the same call at 488, this is a good usage. At first glance it looks wrong, because pipe_read and pipe_write are separate integers. However, they are adjacent in memory since they are inside a struct. They can be used as a two-element array. edit: rewording