Synfig Issue Tracker
star_faded.png
Please log in to bookmark issues
enhancement_small.png
CLOSED  Enhancement #351  -  All layer parameters should be stored internally as ValueBase type
Posted Mar 24, 2013 - updated Jan 05, 2019
action_vote_minus_faded.png
0
Votes
action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Enhancement
  • Status
     
    Closed
  • Assigned to
     Konstantin Dmitriev
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
     Konstantin Dmitriev
  • Owned by
    Not owned by anyone
  • Time spent
    50 hours
  • Category
    Not determined
  • Resolution
    RESOLVED
  • Priority
    Not determined
  • Targetted for
    icon_milestones.png 0.64.1
  • Tags
    icon_customdatatype.png chore
  • Difficulty
    icon_customdatatype.png Easy
Issue description
This is an internal reorganization (chore).

Currently all layer parameters stored as "Real", "bool", etc. types. That means it's impossible to store a custom properties in the parameters (like "static"). For example, because of this "static" properties list is stored in the layer, not in the parameter itself.

It will be more naturally to store all parameters as Value Base nodes. Then we can store additional custom properties attached to parameter.

#3
Comment posted by
 Konstantin Dmitriev
Mar 24, 12:49
I have implemented the basic approach for some parameters already. It could be extended to other parameters.

When everything will be migrated:
  • Don't forget to look for "TODO" marks in the code and remove obsolete pieces of code.
#7
Comment posted by
 Carlos López
Aug 23, 17:20
Applied to master branch

The issue was updated with the following change(s):
  • This issue has been closed
  • The status has been updated, from Being worked on to Closed.
  • This issue's progression has been updated to 100 percent completed.
  • The resolution has been updated, from Not determined to RESOLVED.
  • Time spent on this issue, from No time spent to 50 hours.
  • Information about the user working on this issue has been changed, from Konstantin Dmitriev to Not being worked on.