Synfig Issue Tracker
star_faded.png
Please log in to bookmark issues
enhancement_small.png
CLOSED  Enhancement #161  -  Align rows of Params Panel and Timetrack Panel
Posted Dec 22, 2012 - updated Mar 28, 2015
action_vote_minus_faded.png
1
Votes
action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Enhancement
  • Status
     
    Closed
  • Assigned to
     djay
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
     Imported User
  • Owned by
    Not owned by anyone
  • Time spent
    2 weeks, 3 hours
  • Category
    User interface
  • Resolution
    RESOLVED
  • Priority
    Needs to be fixed
  • Targetted for
    icon_milestones.png 1.0
  • Tags
    icon_customdatatype.png Not determined
  • Difficulty
    icon_customdatatype.png Not determined
Issue description
jcome:

the forum thread for more detail: http://synfig.org/forums/viewtopic.php?f=15&t=2844

#1
Comment posted by
 Imported User
Dec 22, 18:22
A file was uploaded. 0002-Align-rows-of-params-and-timetrack-panels-to-improve.patchicon_open_new.png
#2
Comment posted by
 Imported User
Dec 22, 18:23
genete:

Can you confirm that the patch works for differnt themes and/or font sizes?
#3
Comment posted by
 Imported User
Dec 22, 18:23
jcome:

Yes, tested on my system (Windows and Linux). It is related to theme and font size. rylleman mentioned in the forum thread as well. the better way to avoid this issue is to merge timetrack panel to params panel. I am trying to drafting a mockup for that, once it satisfies me I will post for discuss before the implementation.
#7
Comment posted by
 djay
Mar 19, 11:39
roadmap :
  • get height of param treeview header when style change
  • adjust kf/time of timetrack panel of size according to the treeview header size
actually (in a sample test / gtk3 compliant), i can retrieve some header size according to style ... but with "style = n-1" ... ;-)
#9
Comment posted by
 Konstantin Dmitriev
Mar 19, 12:14
djay:

That would be really nice if this issue will be solved. ^__^

Also, I would like to mention that we have a bounty for this issue - https://www.bountysource.com/issues/1372487-align-rows-of-params-panel-and-timetrack-panel Not much, but if we will spread a word about it the sum might increase.

Good luck!
#10
Comment posted by
 djay
Mar 19, 17:35
good news, my sample project work has expected ! (gtkmm3)

sample project resulticon_open_new.png

I agree to spread a word about it, hopping i can translate this work into synfig (and gtk2) .... but not sure bounty will work...the synfig community has already contributed a lot past month...
#13
Comment posted by
 djay
Mar 28, 09:25
https://github.com/synfig/synfig/pull/119
#15
Comment posted by
 Konstantin Dmitriev
Mar 29, 13:40
A file was uploaded.
align.png
align.pngicon_open_new.png
.
#17
Comment posted by
 Konstantin Dmitriev
Mar 29, 13:43
Hi! Good work, the timetrack is aligned with header now. But the rows of Params Panel and Timetrack Panel are still misaligned. See attached screenshot.

align.png
align.pngicon_open_new.png
#18
Comment posted by
 djay
icon_reply.pngMar 31, 11:50, in reply to comment #17
thank's to test it ;-)

should be good now !

https://github.com/synfig/synfig/pull/120

Konstantin Dmitriev wrote:
Hi!
Good work, the timetrack is aligned with header now. But the rows of Params
Panel and Timetrack Panel are still misaligned. See attached screenshot.

align.png


#20
Comment posted by
 Konstantin Dmitriev
icon_reply.pngMar 31, 12:11, in reply to comment #18
Unfortunately, the fix didn't worked for me - the situation remains the same. smileys/4.png See the screenshot attached.
#21
Comment posted by
 Konstantin Dmitriev
Mar 31, 12:11
A file was uploaded.
synfig-align-rows.png
synfig-align-rows.pngicon_open_new.png
#22
Comment posted by
 djay
icon_reply.pngApr 01, 08:56, in reply to comment #21
That's cool ! after font size, "another" case to fixe ;-).

And better, i have found how to reproduce misaligned rows, setting a personal DPI for font resolution...

Konstantin Dmitriev wrote:
A file was uploaded. synfig-align-rows.png


#26
Comment posted by
 Konstantin Dmitriev
Apr 26, 13:18
Hi, Djay! The fix is merged into master branch. Please claim your bounty here - https://www.bountysource.com/issues/1372487-align-rows-of-params-panel-and-timetrack-panel ^__^
#27
Comment posted by
 djay
Apr 28, 05:35
was a long and "operated by humans remote control" quest ;-)

The issue was updated with the following change(s):
  • This issue's progression has been updated to 100 percent completed.
  • Time spent on this issue, from No time spent to 2 weeks.
  • This issue has been closed
  • The status has been updated, from Ready for testing / QA to Closed.
  • The resolution has been updated, from Not determined to RESOLVED.
#28
Comment posted by
 Yu Chen
Dec 24, 09:42
Hi it returns in master branch (gtk3), see the screenshot: http://synfig.org/forums/download/file.php?id=3104&mode=view