Synfig Issue Tracker
star_faded.png
Please log in to bookmark issues
bug_report_small.png
CLOSED  Bug report #754  -  Onion skin broken
Posted Jan 20, 2015 - updated Jan 05, 2019
action_vote_minus_faded.png
2
Votes
 action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Bug report
  • Status
     
    		 Closed
  • Assigned to
    djay
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
    Carlos López
  • Owned by
    Not owned by anyone
  • Category
    Not determined
  • Resolution
    RESOLVED
  • Priority
    Must fix before next release
  • Targetted for
    icon_milestones.png 1.0
  • Tags
    icon_customdatatype.png onion skin
  • Difficulty
    icon_customdatatype.png Not determined
Issue description
Using master branch development snapshots revision ID 83fd19 windows 32 bits.
Steps to reproduce this issue
Create some keyframes, animate something moving it. Enable onion skin->no onion skin shown.

#2
Comment posted by
Carlos López
Jan 22, 11:17
There used to be two spin widgets to set the past and future onion skin. I miss them in this release.
#6
Comment posted by
djay
icon_reply.pngApr 02, 11:23, in reply to comment #2
un-hidding the onion spins (future and past kf) and onion is working has expected ...

i will push that quick.

Carlos López wrote:
There used to be two spin widgets to set the past and future onion skin. I
miss them in this release.


#7
Comment posted by
Yu Chen
Apr 02, 14:12
I have not look into the recent code of the canvas window toolbar yet, but if it was now using gtk action system as menubar and panel toolbar do. Then spins widget is not supported, Inkscape has same issue and they extend the actions to have ege-adjustment-action.cpp which provides nice customized actions that can solve a awesome solution for this issue.

I dig this before, but can not figure it out due to the limitation of time and code knowledge.

A link for your reference: http://fossies.org/dox/inkscape-0.48.5/ege-adjustment-action_8h.html

good luck!
#8
Comment posted by
djay
icon_reply.pngApr 02, 14:50, in reply to comment #7
Building from gtk 3.4 to gtk 3.12 using toolitem (1), seems to be functional ... the spins widgets are displayed, when they have enough space !

For the cases the toolbar do not fill to display all the 'tools', i have added 'onion skin's 'past' and 'future' preferences into the metadata, and the change can be done from there.

(1) https://developer.gnome.org/gtkmm/stable/classGtk_1_1ToolItem.html#details

Yu Chen wrote:
I have not look into the recent code of the canvas window toolbar yet, but
if it was now using gtk action system as menubar and panel toolbar do.
Then spins widget is not supported, Inkscape has same issue and they extend
the actions to have ege-adjustment-action.cpp which provides nice
customized actions that can solve a awesome solution for this issue.

I dig this before, but can not figure it out due to the limitation of time
and code knowledge.

A link for your reference:
http://fossies.org/dox/inkscape-0.48.5/ege-adjustment-action_8h.html


good luck!


#10
Comment posted by
djay
Apr 02, 14:51
https://github.com/synfig/synfig/pull/176
#12
Comment posted by
Konstantin Dmitriev
icon_reply.pngApr 04, 09:21, in reply to comment #10
Thanks for the fix!

In the future we can improve the situation in the following ways:
  • Change Gtk::SpinButton to Gtk::Entry widget will save a lot of space.
  • Maybe it's worth to allow change number of past/future onionskins through the View menu (much like the same as we can change Preview Quality).