Synfig Issue Tracker ~ [CLOSED] #442 - Add distinction for disabled keyframes on time track panel and or keyframe widget.

Synfig Issue Tracker

CLOSED Enhancement #442 - Add distinction for disabled keyframes on time track panel and or keyframe widget.

Posted May 14, 2013 - updated Jan 05, 2019

Votes

This issue has been closed with status "Closed" and resolution "RESOLVED".

Issue details

Type of issue

Enhancement Unknown issue type
Status

Closed

Status not determined
Assigned to

djay

djay
Offline

This user was last seen online at Apr 23, 2016 - 14:26

Show user details

Close this menu

Not assigned to anyone
Progress
Type of bug

Not triaged
Likelihood

Not triaged
Effect

Not triaged
Posted by

Carlos López

genete
Offline

This user was last seen online at Feb 04, 2016 - 22:57

Show user details

Close this menu
Owned by

Not owned by anyone
Estimated time

No time Not estimated
Time spent

No time No time spent
Category

Not determined
Resolution

RESOLVED Not determined
Priority

Featured Not determined
Reproducability

Not determined
Severity

Not determined
Targetted for

0.64.1 Not determined
Tags

Not determined
Difficulty

Not determined

Issue description

It would be good to have something else that make the user easy to know when a keyframe is disabled just looking the time track panel and not having raised the keyframe panel.

Maybe make the disabled keyframes to have other color, other pattern in the vertical line or draw a vertical triangle in the keyframe widget with other color or shape.

Show system-generated comments

Comment posted on behalf of

djay

Jun 05, 13:53

The issue was updated with the following change(s):

The status has been updated, from New to Being worked on.
The assignee has been changed to djay.

Comment posted by

djay

Jun 05, 13:55

what do you think about Gtk::STATE_INSENSITIVE + Gtk::ARROW_RIGHT ?

active - disabled - current

Comment posted on behalf of

djay

Jun 05, 17:49

The issue was updated with the following change(s):

The status has been updated, from Being worked on to Near completion.
This issue's progression has been updated to 90 percent completed.

Comment posted by

Konstantin Dmitriev

Jun 06, 03:15, in reply to comment #2

djay wrote:

what do you think about Gtk::STATE_INSENSITIVE + Gtk::ARROW_RIGHT ?

I think Gtk::STATE_INSENSITIVE is not desirable, since keyframe should remains editable. I would prefer ordinary keyframes to become bolder and disable could have dotted lines.

Comment posted by

djay

Jun 06, 08:00, in reply to comment #4

I think Gtk::STATE_INSENSITIVE is not desirable, since keyframe should
remains editable.

They still are editable, Gtk::STATE_INSENSITIVE in this case, is just a visual state, this do not affect the "image comportement"...

With my patch, even disabled and insensitive styled, i can move (d&d) the disabled keyframe in the timetrack panel and i can adjust kf properties in keyframe panel.

I would prefer ordinary keyframes to become bolder and
disable could have dotted lines.

Sorry, but, i do not want to change (now) the ordinary keyframes appearance (cause of too much screenshot update to think ;-) , in some months maybe for another major ui update ?
Disabled dotted, will take look to that idea, but it did not find something approaching quickly ...

what do you think ?

Comment posted by

djay

Jun 06, 18:37, in reply to comment #5

let's try it like that...

Comment posted on behalf of

djay

Jun 06, 19:07

The issue was updated with the following change(s):

This issue's progression has been updated to 100 percent completed.
The status has been updated, from Near completion to Done.

Comment posted by

djay

Jul 20, 13:28, in reply to comment #6

note : timebar from graph panel do not hold keyframe position....

djay wrote:

let's try it like that...

Comment posted on behalf of

Konstantin Dmitriev

Sep 11, 11:21

The issue was updated with the following change(s):

The status has been updated, from Done to Ready for testing / QA.
Information about the user working on this issue has been changed, from djay to Not being worked on.